Re: [PATCH 2/3] do_migrate_range: exit loop if not_managed is true.

[Bob Liu <lliubbo@xxxxxxxxx>]

On Fri, Oct 22, 2010 at 11:16 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> On Thu, 21 Oct 2010 21:28:20 +0800
> Bob Liu <lliubbo@xxxxxxxxx> wrote:
>
>> If not_managed is true all pages will be putback to lru, so
>> break the loop earlier to skip other pages isolate.
>>
>> Signed-off-by: Bob Liu <lliubbo@xxxxxxxxx>
>
> please don't skip dump_page().
>

Hi, Kame

I put the check after dump_page() in order to we can still see the
dump message if the loop is broken earlier.

Thanks

> -Kame
>
>> ---
>> Âmm/memory_hotplug.c | Â 10 ++++++----
>> Â1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index d4e940a..4f72184 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -709,15 +709,17 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â page_is_file_cache(page));
>>
>> Â Â Â Â Â Â Â } else {
>> - Â Â Â Â Â Â Â Â Â Â /* Becasue we don't have big zone->lock. we should
>> - Â Â Â Â Â Â Â Â Â Â Â Âcheck this again here. */
>> - Â Â Â Â Â Â Â Â Â Â if (page_count(page))
>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â not_managed++;
>> Â#ifdef CONFIG_DEBUG_VM
>> Â Â Â Â Â Â Â Â Â Â Â printk(KERN_ALERT "removing pfn %lx from LRU failed\n",
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âpfn);
>> Â Â Â Â Â Â Â Â Â Â Â dump_page(page);
>> Â#endif
>> + Â Â Â Â Â Â Â Â Â Â /* Becasue we don't have big zone->lock. we should
>> + Â Â Â Â Â Â Â Â Â Â Â Âcheck this again here. */
>> + Â Â Â Â Â Â Â Â Â Â if (page_count(page)) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â not_managed++;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â break;
>> + Â Â Â Â Â Â Â Â Â Â }
>> Â Â Â Â Â Â Â }
>> Â Â Â }
>> Â Â Â ret = -EBUSY;
-- 
Regards,
--Bob
ÿô.nlj·ÿ±ég¬±¨Âaþé»®&Þ)î¦þ)íèh™¨è&£ù¢¸ÿŠæ¢ú»þÇþm§ÿÿÃÿ–)î¦þŠàè^™¨¥ÿö™¨¥¶ÿv‰íÚOèÿzf¢—ù¢¸ÿ