On Mon 04-04-16 11:23:43, Vladimir Davydov wrote: > On Tue, Dec 15, 2015 at 07:19:44PM +0100, Michal Hocko wrote: > ... > > @@ -2592,17 +2589,10 @@ static bool shrink_zones(struct zonelist *zonelist, struct scan_control *sc) > > &nr_soft_scanned); > > sc->nr_reclaimed += nr_soft_reclaimed; > > sc->nr_scanned += nr_soft_scanned; > > - if (nr_soft_reclaimed) > > - reclaimable = true; > > /* need some check for avoid more shrink_zone() */ > > } > > > > - if (shrink_zone(zone, sc, zone_idx(zone) == classzone_idx)) > > - reclaimable = true; > > - > > - if (global_reclaim(sc) && > > - !reclaimable && zone_reclaimable(zone)) > > - reclaimable = true; > > + shrink_zone(zone, sc, zone_idx(zone)); > > Shouldn't it be > > shrink_zone(zone, sc, zone_idx(zone) == classzone_idx); > > ? I cannot remember the reason why I have removed it so it is more likely this was unintentional. Thanks for catching this. I will fold it into the original patch before I repost the full series (this week hopefully). -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>