On Mon, Mar 21, 2016 at 12:29:34PM -0500, Christoph Lameter wrote: > On Mon, 21 Mar 2016, Kirill A. Shutemov wrote: > > > We do have two page sizes in the page cache. It's the only option to get > > transparent huge pages transparent. > > Should then not PAGE_CACHE_SIZE take a page parameter and return the > correct page size? Why? What would you achieve by this? We already have a way to find out size of page: compoun_order() or hpage_nr_pages(). And not in every place where PAGE_CACHE_SIZE is used we have corresponding struct page. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>