On Wed, Mar 09, 2016 at 12:15:10AM +0900, Tetsuo Handa wrote: > Since mem_cgroup_out_of_memory() is called by > mem_cgroup_oom_synchronize(true) via pagefault_out_of_memory() via > page fault, and possible allocations between setting PF_EXITING and > calling exit_mm() are tty_audit_exit() and taskstats_exit() which will > not trigger page fault, task_will_free_mem(current) in > mem_cgroup_out_of_memory() is never true. > > Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> This opens us up to subtle bugs when somebody later changes the order and adds new possible allocation sites between the sequence points you describe above, or maybe adds other mem_cgroup_out_of_memory() callers. It looks like a simplification, but it actually complicates things. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>