Hi, On Tue, Oct 19, 2010 at 01:49:12PM +0900, KOSAKI Motohiro wrote: > Hi > > > Index: linux-2.6/include/linux/mm.h > > =================================================================== > > --- linux-2.6.orig/include/linux/mm.h 2010-10-19 14:19:40.000000000 +1100 > > +++ linux-2.6/include/linux/mm.h 2010-10-19 14:36:48.000000000 +1100 > > @@ -997,6 +997,10 @@ > > /* > > * A callback you can register to apply pressure to ageable caches. > > * > > + * 'shrink_zone' is the new shrinker API. It is to be used in preference > > + * to 'shrink'. One must point to a shrinker function, the other must > > + * be NULL. See 'shrink_slab' for details about the shrink_zone API. > ... > Now we decided to don't remove old (*shrink)() interface and zone unaware > slab users continue to use it. so why do we need global argument? > If only zone aware shrinker user (*shrink_zone)(), we can remove it. > > Personally I think we should remove it because a removing makes a clear > message that all shrinker need to implement zone awareness eventually. I agree, I do want to remove the old API, but it's easier to merge if I just start by adding the new API. It is split out from my previous patch which does convert all users of the API. When this gets merged, I will break those out and send them via respective maintainers, then remove the old API when they're all converted upstream. Thanks, Nick -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>