On Fri, 26 Feb 2016, Chen Gang wrote: > > git blame identifies what commit last altered a line. If a cleanup patch > > is encountered then the tree before that commit needs to be examined > > which adds time. It's rare that cleanup patches on their own are useful > > and this is one of those cases. > > git is a tool mainly for analyzing code, but not mainly for normal > reading main code. > > So for me, the coding styles need not consider about git. You are mistaken here. It's very helpful when debugging; usually you want to find the commit that introduced particular change, and read its changelog (at least). Having to cross rather pointless changes just adds time (need to restart git-blame with commit~1 as a base) for no really good reason. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>