On Wed, Feb 24, 2016 at 06:58:03PM +0300, Kirill A. Shutemov wrote: > Sebastian Ott and Gerald Schaefer reported random crashes on s390. > It was bisected to my THP refcounting patchset. > > The problem is that pmdp_invalidated() called with wrong virtual > address. It got offset up by HPAGE_PMD_SIZE by loop over ptes. > > The solution is to introduce new variable to be used in loop and don't > touch 'haddr'. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx> > Reported-by: Gerald Schaefer <gerald.schaefer@xxxxxxxxxx> > Reported-by Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx> > --- > mm/huge_memory.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Looks good to me: Reviewed-by: Will Deacon <will.deacon@xxxxxxx> Thanks, Will -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>