On Mon, Feb 08, 2016 at 05:53:17PM +0400, Dmitry Monakhov wrote:
> - dax_radix_entry_insert is more appropriate name for that function
I think I may have actually had it named that at some point. :) I changed it
because it doesn't always insert an entry - in the read case for example we
insert a clean entry, and then on the following dax_pfn_mkwrite() we call back
in and mark it as dirty.
> - Add lockless helper __dax_radix_entry_insert, it will be used by second patch
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
> ---
> fs/dax.c | 39 +++++++++++++++++++++++----------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index fc2e314..89bb1f8 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
<>
> @@ -579,8 +586,8 @@ static int dax_insert_mapping(struct inode *inode, struct buffer_head *bh,
> }
> dax_unmap_atomic(bdev, &dax);
>
> - error = dax_radix_entry(mapping, vmf->pgoff, dax.sector, false,
> - vmf->flags & FAULT_FLAG_WRITE);
> + error = dax_radix_entry_insert(mapping, vmf->pgoff, dax.sector, false,
> + vmf->flags & FAULT_FLAG_WRITE, vmf->page);
fs/dax.c: In function ‘dax_insert_mapping’:
fs/dax.c:589:10: error: too many arguments to function ‘dax_radix_entry_insert’
error = dax_radix_entry_insert(mapping, vmf->pgoff, dax.sector, false,
^
fs/dax.c:415:12: note: declared here
static int dax_radix_entry_insert(struct address_space *mapping, pgoff_t index,
^
scripts/Makefile.build:258: recipe for target 'fs/dax.o' failed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>