> On Wed, Oct 13, 2010 at 03:27:12PM +0900, KOSAKI Motohiro wrote: > > Currently, memory hotplu call setup_per_zone_wmarks() and > > calculate_zone_inactive_ratio(), but don't call setup_per_zone_lowmem_reserve. > > > > It mean number of reserved pages aren't updated even if memory hot plug > > occur. This patch fixes it. > > > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > Ok, I see the logic although the changelog needs a better description as > to why this matters and what the consequences are. It appears unrelated > to Shaohua's problem for example. Otherwise the patch looks reasonable > > Acked-by: Mel Gorman <mel@xxxxxxxxx> patch [1/3] and [2/3] is necessary for avoiding [3/3] break memory hotplug. When memory hotplug occur, we need to update _all_ zone->present_pages related vm parameters. otherwise they might become inconsistent and no workable. more detail: [3/3] depend on setup_per_zone_wmarks() is always called after refresh_zone_stat_thresholds(). patch [1/3] and [2/3] does. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>