On Thu, Feb 04, 2016 at 03:52:10PM -0500, Johannes Weiner wrote: > On Thu, Feb 04, 2016 at 04:03:39PM +0300, Vladimir Davydov wrote: > > Show how much memory is allocated to kernel stacks. > > > > Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx> > > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks. > > Thanks, this looks good. The only thing that strikes me is that you > appended the new stat items to the enum, but then prepended them to > the doc and stat file sections. Why is that? No reason. Let's rearrange the enum fields to be consistent with the stat file output. diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index aaf564881303..d6300313b298 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -52,10 +52,10 @@ enum mem_cgroup_stat_index { MEM_CGROUP_STAT_SWAP, /* # of pages, swapped out */ MEM_CGROUP_STAT_NSTATS, /* default hierarchy stats */ - MEMCG_SOCK = MEM_CGROUP_STAT_NSTATS, + MEMCG_KERNEL_STACK = MEM_CGROUP_STAT_NSTATS, MEMCG_SLAB_RECLAIMABLE, MEMCG_SLAB_UNRECLAIMABLE, - MEMCG_KERNEL_STACK, + MEMCG_SOCK, MEMCG_NR_STAT, }; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>