Konstantin pointed out my braino when using radix_tree_iter_retry(), and then pointed out a second braino. I think we can fix both brainos with one simple test (the advantage of having your braino pointed out to you is that you know what you were expecting to happen, so you can sometimes propose simlpy making happen what you expected to happen. Konstantin doesn't have access to my though tprocesses.) Kontantin wrote a really great test ... and then didn't add it to the test suite. That made me sad, so I added it. Andrew, can you drop radix-tree-fix-oops-after-radix_tree_iter_retry.patch from your tree and add these two patches instead? If you prefer Konstantin's fix to this one, I'll send you another patch to fix the second problem Konstantin pointed out. I was a bit unsure about the proper attribution here. The essentials of the test-suite change from Konstantin are unchanged, but he didn't have his own sign-off on it. So I made him 'From' and only added my own sign-off. Konstantin Khlebnikov (1): radix-tree tests: Add regression3 test Matthew Wilcox (1): radix-tree: fix oops after radix_tree_iter_retry include/linux/radix-tree.h | 3 ++ tools/testing/radix-tree/Makefile | 2 +- tools/testing/radix-tree/linux/kernel.h | 1 + tools/testing/radix-tree/main.c | 1 + tools/testing/radix-tree/regression.h | 1 + tools/testing/radix-tree/regression3.c | 86 +++++++++++++++++++++++++++++++++ 6 files changed, 93 insertions(+), 1 deletion(-) create mode 100644 tools/testing/radix-tree/regression3.c -- 2.7.0.rc3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>