On Fri, Jan 29, 2016 at 11:28:59AM +0100, Vlastimil Babka wrote: > On 01/29/2016 08:06 AM, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 735cfa51151aeae6df04074165aa36b42481df86 > > commit: e8bd33570a656979c09ce66a11ca8864fda8ad0c [1875/2100] mm, printk: introduce new format string for flags-fix > > config: s390-allyesconfig (attached as .config) > > reproduce: > > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout e8bd33570a656979c09ce66a11ca8864fda8ad0c > > # save the attached .config to linux build tree > > make.cross ARCH=s390 > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/static_key.h:1:0, > > from include/linux/tracepoint-defs.h:11, > > from include/linux/mmdebug.h:6, > > from arch/s390/include/asm/cmpxchg.h:10, > > from arch/s390/include/asm/atomic.h:19, > > from include/linux/atomic.h:4, > > from include/linux/debug_locks.h:5, > > from include/linux/lockdep.h:23, > > from include/linux/hardirq.h:5, > > from include/linux/kvm_host.h:10, > > from arch/s390/kernel/asm-offsets.c:10: > > include/linux/jump_label.h: In function 'static_key_count': > >>> include/linux/jump_label.h:122:2: error: implicit declaration of function 'atomic_read' [-Werror=implicit-function-declaration] > > return atomic_read(&key->enabled); > > Sigh. > > I don't get it, there's "#include <linux/atomic.h>" in jump_label.h right before > it gets used. So, what implicit declaration? > > BTW, do you really need to use VM_BUG_ON() and thus include mmdebug.h in > arch/s390/include/asm/cmpxchg.h ? Is that assertion really related to VM? That's more or less copied over from x86 (and arm64 has it too). Probably because the only user used to be SLUB and the author has a strong memory management background :) However, I'd like to keep the sanity check. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>