Re: [linux-next:master 1860/2084] include/linux/mm.h:1602:2: note: in expansion of macro 'spin_lock_init'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/28/2016 08:23 AM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   888c8375131656144c1605071eab2eb6ac49abc3
> commit: cec08ed70d3d5209368a435fed278ae667117a0c [1860/2084] mm, printk: introduce new format string for flags
> config: s390-allyesconfig (attached as .config)
> reproduce:
>          wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          git checkout cec08ed70d3d5209368a435fed278ae667117a0c
>          # save the attached .config to linux build tree
>          make.cross ARCH=s390
> 
> All error/warnings (new ones prefixed by >>):
> 
>     In file included from include/linux/spinlock.h:81:0,
>                      from include/linux/rcupdate.h:38,
>                      from include/linux/tracepoint.h:19,
>                      from include/linux/mmdebug.h:7,
>                      from arch/s390/include/asm/cmpxchg.h:10,
>                      from arch/s390/include/asm/atomic.h:19,
>                      from include/linux/atomic.h:4,
>                      from include/linux/debug_locks.h:5,
>                      from include/linux/lockdep.h:23,
>                      from include/linux/hardirq.h:5,
>                      from include/linux/kvm_host.h:10,
>                      from arch/s390/kernel/asm-offsets.c:10:
>>> include/linux/spinlock_types.h:30:21: error: field 'dep_map' has incomplete type
>       struct lockdep_map dep_map;
>                          ^

Damn, a rebasing mistake in my series, sorry about that.
This should help. Can it be applied to -next? I think Andrew said he
would be travelling...

----8<----
>From b2cc2250d3c71321279388a076bafc304d3ffac5 Mon Sep 17 00:00:00 2001
From: Vlastimil Babka <vbabka@xxxxxxx>
Date: Thu, 28 Jan 2016 18:29:58 +0100
Subject: [PATCH] mm, printk: introduce new format string for flags-fix

We should be using include/tracepoint-defs.h, not full tracepoint.h, to
prevent header dependency issues on some arches.
Also remove the same definitions from mm/internal.h (a rebasing mistake).

Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
---
 include/linux/mmdebug.h | 3 +--
 mm/internal.h           | 5 -----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
index 3fb9bc65d61d..adef2dee268e 100644
--- a/include/linux/mmdebug.h
+++ b/include/linux/mmdebug.h
@@ -3,8 +3,7 @@
 
 #include <linux/bug.h>
 #include <linux/stringify.h>
-#include <linux/types.h>
-#include <linux/tracepoint.h>
+#include <linux/tracepoint-defs.h>
 
 struct page;
 struct vm_area_struct;
diff --git a/mm/internal.h b/mm/internal.h
index cac6eb458727..9e31d1dc67ae 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -14,7 +14,6 @@
 #include <linux/fs.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
-#include <linux/tracepoint-defs.h>
 
 /*
  * The set of flags that only affect watermark checking and reclaim
@@ -462,8 +461,4 @@ static inline void try_to_unmap_flush_dirty(void)
 
 #endif /* CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH */
-
-extern const struct trace_print_flags pageflag_names[];
-extern const struct trace_print_flags vmaflag_names[];
-extern const struct trace_print_flags gfpflag_names[];
-
 #endif	/* __MM_INTERNAL_H */
-- 
2.7.0


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]