On Mon, Jan 25, 2016 at 04:44:59PM +0100, Petr Mladek wrote: > +bool mod_delayed_kthread_work(struct kthread_worker *worker, > + struct delayed_kthread_work *dwork, > + unsigned long delay) > +{ > + struct kthread_work *work = &dwork->work; > + unsigned long flags; > + int ret = 0; > + > +try_again: > + spin_lock_irqsave(&worker->lock, flags); > + WARN_ON_ONCE(work->worker && work->worker != worker); > + > + if (work->canceling) > + goto out; > + > + ret = try_to_cancel_kthread_work(work, &worker->lock, &flags); > + if (ret == -EAGAIN) > + goto try_again; > + > + if (work->canceling) Does this test need to be repeated? How would ->canceling change while worker->lock is held? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>