Re: [PATCH v2] mm/debug_pagealloc: Ask users for default setting of debug_pagealloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On ma, 2016-01-25 at 12:15 +0100, Christian Borntraeger wrote:
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug

> +config DEBUG_PAGEALLOC_ENABLE_DEFAULT
> +	bool "Enable debug page memory allocations by default?"
> +        default off

Nit: you apparently meant
	default n

Note that "default off" should also evaluate to "n", which probably
explains why you didn't notice. And "n" is the default anyhow.

So I'm guessing you might as well drop this line.

> +        depends on DEBUG_PAGEALLOC
> +        ---help---
> +	  Enable debug page memory allocations by default? This value
> +	  can be overridden by debug_pagealloc=off|on.
> +
> +	  If unsure say no.

(Really trivial: you start indentation both with spaces and with tabs.
Start with tabs, please.)


Paul Bolle

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]