On Thu, 14 Jan 2016, Joonsoo Kim wrote: > /* > * Calculate the number of objects and left-over bytes for a given buffer size. > */ > static void cache_estimate(unsigned long gfporder, size_t buffer_size, > - size_t align, int flags, size_t *left_over, > - unsigned int *num) > + unsigned long flags, size_t *left_over, unsigned int *num) > { Return the number of objects from the function? Avoid returning values by reference. left_over is already bad enough. Otherwise Acked-by: Christoph Lameter <cl@xxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>