On Mon, Dec 21, 2015 at 6:38 PM, Christoph Lameter <cl@xxxxxxxxx> wrote:
> Index: linux/mm/vmstat.c
> ===================================================================
> --- linux.orig/mm/vmstat.c
> +++ linux/mm/vmstat.c
> @@ -1419,11 +1419,9 @@ void quiet_vmstat(void)
> if (system_state != SYSTEM_RUNNING)
> return;
>
> - do {
> - if (!cpumask_test_and_set_cpu(smp_processor_id(), cpu_stat_off))
> - cancel_delayed_work(this_cpu_ptr(&vmstat_work));
> -
> - } while (refresh_cpu_vm_stats(false));
> + refresh_cpu_vm_stats(false);
> + cancel_delayed_work(this_cpu_ptr(&vmstat_work));
>
shouldn't this be cancel_delayed_work_sync ?
> + cpumask_set_cpu(smp_processor_id(), cpu_stat_off);
>
else ongoing vmstat_update can again encounter cpu_stat_off set ?
> }
>
--
regards
Shiraz Hashim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>