On Mon 11-01-16 21:15:01, Xishi Qiu wrote: > On 2016/1/11 20:25, Michal Hocko wrote: > > > On Mon 11-01-16 11:54:57, Xishi Qiu wrote: > >> Add ratio(active_objs/num_objs) in /proc/slabinfo, it is used to show > >> the availability factor in each slab. > > > > What is the reason to add such a new value when it can be trivially > > calculated from the userspace? > > > > Besides that such a change would break existing parsers no? > > Oh, maybe it is. > > How about adjustment the format because some names are too long? Parsers should be clever enough to process white spaces properly but there is no guarantee this will be the case. A more important question is whether it really makes sense to change this in the first place. What would be the benefit? Somehow nicer output? Does this justify a potential breakage of tool processing this file? To me this all sounds like such a change is not worth it. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>