Re: [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 07, 2010 at 09:31:20AM +0900, Naoya Horiguchi wrote:
> > @@ -198,7 +199,8 @@ static int kill_proc_ao(struct task_struct *t, unsigned long addr, int trapno,
> >  #ifdef __ARCH_SI_TRAPNO
> >  	si.si_trapno = trapno;
> >  #endif
> > -	si.si_addr_lsb = PAGE_SHIFT;
> > +	order = PageCompound(page) ? huge_page_order(page) : PAGE_SHIFT;
>                                                      ^^^^
>                                      huge_page_order(page_hstate(page)) ?

Ok.

> >  				printk(KERN_ERR
> >  		"MCE %#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
> > -					pfn, tk->tsk->comm, tk->tsk->pid);
> > +					pfn,	
> > +					tk->tsk->comm, tk->tsk->pid);
> 
> What's the point of this change?

Probably left over from an earlier version; I will drop that hunk thanks.


-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]