On Wed, Oct 06, 2010 at 01:07:04PM +0200, Gleb Natapov wrote: > > Can't you set a bit in vcpu->requests instead, and handle it in "out:" > > at the end of vcpu_enter_guest? > > > > To have a single entry point for pagefaults, after vmexit handling. > Jumping to "out:" will skip vmexit handling anyway, so we will not reuse > same call site anyway. I don't see yet why the way you propose will have > an advantage. What i meant was to call pagefault handler after vmexit handling. Because the way it is in your patch now, with pre pagefault on entry, one has to make an effort to verify ordering wrt other events on entry processing. With pre pagefault after vmexit, its more natural. Does that make sense? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>