On 10/01/2010 01:52 PM, Robin Holt wrote:
> On Fri, Oct 01, 2010 at 01:31:51PM -0500, Nathan Fontenot wrote:
>> Update the memory sysfs code such that each sysfs memory directory is now
>> considered a memory block that can span multiple memory sections per
>> memory block. The default size of each memory block is SECTION_SIZE_BITS
>> to maintain the current behavior of having a single memory section per
>> memory block (i.e. one sysfs directory per memory section).
>>
>> For architectures that want to have memory blocks span multiple
>> memory sections they need only define their own memory_block_size_bytes()
>> routine.
>>
>> Signed-off-by: Nathan Fontenot <nfont@xxxxxxxxxxxxxx>
>>
>> ---
>> drivers/base/memory.c | 155 ++++++++++++++++++++++++++++++++++----------------
>> 1 file changed, 108 insertions(+), 47 deletions(-)
>>
>> Index: linux-next/drivers/base/memory.c
>> ===================================================================
>> --- linux-next.orig/drivers/base/memory.c 2010-09-30 14:13:50.000000000 -0500
>> +++ linux-next/drivers/base/memory.c 2010-09-30 14:46:00.000000000 -0500
> ...
>> +static unsigned long get_memory_block_size(void)
>> +{
>> + u32 block_sz;
> ^^^
>
> I think this should be unsigned long. u32 will work, but everything
> else has been changed to use unsigned long. If you disagree, I will
> happily acquiesce as nothing is currently broken. If SGI decides to make
> memory_block_size_bytes more dynamic, we will fix this up at that time.
You're right, that should have been made an unsigned long also. I'll attach a new
patch with that corrected.
-Nathan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>