> > > > PTE-referenced PageAnon() pages are activated unconditionally a few > > > > lines further up, so the page_is_file_cache() check filters only shmem > > > > pages. I doubt this was your intention...? > > > This is intented. the executable page protect is just to protect > > > executable file pages. please see 8cab4754d24a0f. > > > > 8cab4754d24a0f was using !PageAnon() but your one are using page_is_file_cache. > > 8cab4754d24a0f doesn't tell us the reason of the change, no? > > What if the executable file happen to be on tmpfs? The !PageAnon() > test also covers that case. The page_is_file_cache() test here seems > unnecessary. And it looks better to move the VM_EXEC test above the > SetPageReferenced() line to avoid possible side effects. Both agree :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>