Re: [Slub cleanup5 2/3] SLUB: Pass active and inactive redzone flags instead of boolean to debug functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 28 Sep 2010, Christoph Lameter wrote:

> @@ -1075,8 +1071,9 @@ static inline int free_debug_processing(
>  static inline int slab_pad_check(struct kmem_cache *s, struct page *page)
>  			{ return 1; }
>  static inline int check_object(struct kmem_cache *s, struct page *page,
> -			void *object, int active) { return 1; }
> -static inline void add_full(struct kmem_cache_node *n, struct page *page) {}
> +			void *object, u8 val) { return 1; }
> +static inline void add_full(struct kmem_cache *s,
> +		struct kmem_cache_node *n, struct page *page) {}
>  static inline unsigned long kmem_cache_flags(unsigned long objsize,
>  	unsigned long flags, const char *name,
>  	void (*ctor)(void *))

Looks like add_full() got changed there for CONFIG_SLUB_DEBUG=n 
unintentionally.

I'm wondering if we should make that option configurable regardless of 
CONFIG_EMBEDDED, it's a large savings if you're never going to be doing 
any debugging on Pekka's for-next:

   text	   data	    bss	    dec	    hex	filename
  25817	   1473	    288	  27578	   6bba	slub.o.debug
  10742	    232	    256	  11230	   2bde	slub.o.nodebug

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]