>> +static void copy_gigantic_page(struct page *dst, struct page *src) >> +{ >> + int i; >> + struct hstate *h = page_hstate(src); >> + struct page *dst_base = dst; >> + struct page *src_base = src; >> + >> + for (i = 0; i < pages_per_huge_page(h); ) { >> + cond_resched(); > > Should this function not have a might_sleep() check too? cond_resched() implies might_sleep I believe. I think that answers the earlier question too becuse that function calls this. /* > > Other than the removal of the might_sleep() check, this looks ok too. Can I assume an Ack? Thanks, -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>