On Mon, Sep 06, 2010 at 02:02 -0700, David Rientjes wrote: > On Mon, 6 Sep 2010, KOSAKI Motohiro wrote: > > > > From: Vasiliy Kulikov <segooon@xxxxxxxxx> > > > > > > Function check_range may return ERR_PTR(...). Check for it. > > > > When happen this issue? > > > > afaik, check_range return error when following condition. > > 1) mm->mmap->vm_start argument is incorrect > > 2) don't have neigher MPOL_MF_STATS, MPOL_MF_MOVE and MPOL_MF_MOVE_ALL > > > > I think both case is not happen in real. Am I overlooking anything? > > > > There's no reason not to check the return value of a function when the > implementation of either could change at any time. migrate_to_node() is > certainly not in any fastpath where we can't sacrifice a branch for more > robust code. Agreed, if you know that the caller must check input data and must not check return code, it's better to make this function return void. -- Vasiliy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>