On Mon, 6 Sep 2010, KOSAKI Motohiro wrote: > > From: Vasiliy Kulikov <segooon@xxxxxxxxx> > > > > Use IS_ERR() instead of strict checking. > > Umm... > > I don't like this. IS_ERR() imply an argument is error code. but in > this case, we don't use error code. -1 mean oom special purpose meaning > value. > You could make the same argument by saying the current use of PTR_ERR() implies an error code. We've simply hijacked -1UL for simplicity in this case and because select_bad_process() can only return one other value besides a pointer to a process or NULL. > So, if we take this direction, It would be better to use EAGAIN or something > instead -1. > I agree it would probably better to return ERR_PTR(-EAGAIN) instead of using -1UL. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>