On Fri, 3 Sep 2010, Andrea Arcangeli wrote: > From: Andrea Arcangeli <aarcange@xxxxxxxxxx> > > The pte_same check is reliable only if the swap entry remains pinned > (by the page lock on swapcache). We've also to ensure the swapcache > isn't removed before we take the lock as try_to_free_swap won't care > about the page pin. > > Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> Acked-by: Hugh Dickins <hughd@xxxxxxxxxx> Yes, it's a great little find, and long predates the KSM hooks you've had to adjust. It does upset me (aesthetically) that the KSM case now intrudes into do_swap_swap() much more than it used to; but I have not come up with a better solution, so yes, let's go forward with this. Thanks, Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>