Re: [PATCH 1/2] Add trace points to mmap, munmap, and brk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 27 Jul 2010, KOSAKI Motohiro wrote:

> > On Wed, 21 Jul 2010, KOSAKI Motohiro wrote:
> > 
> > > > This patch adds trace points to mmap, munmap, and brk that will report
> > > > relevant addresses and sizes before each function exits successfully.
> > > > 
> > > > Signed-off-by: Eric B Munson <emunson@xxxxxxxxx>
> > > 
> > > I don't think this is good idea. if you need syscall result, you should 
> > > use syscall tracer. IOW, This tracepoint bring zero information.
> > > 
> > > Please see perf_event_mmap() usage. Our kernel manage adress space by
> > > vm_area_struct. we need to trace it if we need to know what kernel does.
> > > 
> > > Thanks.
> > 
> > The syscall tracer does not give you the address and size of the mmaped areas
> > so this does provide information above simply tracing the enter/exit points
> > for each call.
> 
> Why don't you fix this?
> 
> 

Sorry for the long delay, the enter/exit routines are not compatible with the
information that these new trace points provides.  When tracing mmap, for
instance, the addr and len arguments can be altered by the function.  If you
use the enter/exit trace points you would not see this as the arguments are
sampled at function entrance and not given again on exit.  Also, the new
trace points are only hit on function success, the exit trace point happens
any time you leave the system call.

I will send out a new series after a rebase.

Thanks,
Eric

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]