On Tue, Aug 24, 2010 at 2:17 AM, Christoph Lameter <cl@xxxxxxxxx> wrote: > On Tue, 24 Aug 2010, Minchan Kim wrote: > >> On Mon, Aug 23, 2010 at 11:41:49AM -0500, Christoph Lameter wrote: >> > On Tue, 24 Aug 2010, Minchan Kim wrote >> > >> > > This patch introude new argument 'cleanup' to migrate_pages. >> > > Only if we set 1 to 'cleanup', migrate_page will clean up the lists. >> > > Otherwise, caller need to clean up the lists so it has a chance to postprocess >> > > the pages. >> > >> > Could we simply make migrate_pages simply not do any cleanup? >> > Caller has to call putback_lru_pages()? >> > >> Hmm. maybe I misunderstood your point. >> Your point is that let's make whole caller of migrate_pagse has a responsibility >> of clean up the list? > > Yes. All callers would be responsible for cleanup. Yes. I hoped it but try to maintain API semantics. But if you agree to change it, I will do it. Will repost. Thanks, Christoph. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>