On Tue, 24 Aug 2010 08:49:16 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > On Mon, 23 Aug 2010 17:50:15 +0900 > Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote: > > > This patch looks good to me, but I have one question. > > > > Why do we need to acquire sc.lock inside mem_cgroup_(start|end)_move() ? > > These functions doesn't access mc.*. > > > > just reusing a lock to update status. If you don't like, I'll add a new lock. > I see. I think it would be enough just to add some comments about it. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>