On Mon, Aug 23, 2010 at 11:08:06AM -0500, Christoph Lameter wrote: > On Mon, 23 Aug 2010, Gleb Natapov wrote: > > > > The guest will have to align this on a 64 byte boundary, should this > > > be marked __aligned(64) here? > > > > > I do __aligned(64) when I declare variable of that type: > > > > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); > > 64 byte boundary: You mean cacheline aligned? We have a special define for > that. > > DEFINE_PER_CPU_SHARED_ALIGNED IIRC I tried to use it and it does different alignment on 64/32 bit. The alignment here is part of guest/host interface so it should be the same on both. -- Gleb. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>