On 08/04/2010 11:53 PM, KAMEZAWA Hiroyuki wrote: > On Tue, 03 Aug 2010 08:39:50 -0500 > Nathan Fontenot <nfont@xxxxxxxxxxxxxx> wrote: > >> Add a new mutex for use in adding and removing of memory blocks. This >> is needed to avoid any race conditions in which the same memory block could >> be added and removed at the same time. >> >> Signed-off-by: Nathan Fontenot <nfont@xxxxxxxxxxxxxx> > > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > But a nitpick (see below) > >> --- >> drivers/base/memory.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> Index: linux-2.6/drivers/base/memory.c >> =================================================================== >> --- linux-2.6.orig/drivers/base/memory.c 2010-08-02 13:35:00.000000000 -0500 >> +++ linux-2.6/drivers/base/memory.c 2010-08-02 13:45:34.000000000 -0500 >> @@ -27,6 +27,8 @@ >> #include <asm/atomic.h> >> #include <asm/uaccess.h> >> >> +static struct mutex mem_sysfs_mutex; >> + > > For static symbol of mutex, we usually do > static DEFINE_MUTEX(mem_sysfs_mutex); > > Then, extra calls of mutex_init() is not required. > ok, fixed in the next version of the patches. -Nathan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>