On Mon, Jul 19, 2010 at 10:15:01AM -0400, Christoph Hellwig wrote: > On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote: > > It is useful to distinguish between IO for anon and file pages. This > > patch updates > > vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include > > that information. The patches can be merged together. > > I think the trace would be nicer if you #define flags for both > cases and then use __print_flags on them. That'll also make it more > extensible in case we need to add more flags later. > Not a bad idea, I'll check it out. Thanks. The first flags would be; RECLAIM_WB_ANON RECLAIM_WB_FILE Does anyone have problems with the naming? > And a purely procedural question: This is supposed to get rolled into > the original patch before it gets commited to a git tree, right? > That is my expectation. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>