On Fri, Jul 16, 2010 at 07:13:31PM +0900, KOSAKI Motohiro wrote: > Currently, mem_cgroup_shrink_node_zone() initialize sc.nr_to_reclaim as 0. > It mean shrink_zone() only scan 32 pages and immediately return even if > it doesn't reclaim any pages. > Do you mean it immediately returns once one page is reclaimed? i.e. this check if (nr_reclaimed >= nr_to_reclaim && priority < DEF_PRIORITY) break; > This patch fixes it. > Otherwise it seems ok. It's unrelated to trace points though so should be submitted on its own. > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> Acked-by: Mel Gorman <mel@xxxxxxxxx> > --- > mm/vmscan.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 1691ad0..bd1d035 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1932,6 +1932,7 @@ unsigned long mem_cgroup_shrink_node_zone(struct mem_cgroup *mem, > struct zone *zone, int nid) > { > struct scan_control sc = { > + .nr_to_reclaim = SWAP_CLUSTER_MAX, > .may_writepage = !laptop_mode, > .may_unmap = 1, > .may_swap = !noswap, > -- > 1.6.5.2 > > > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>