On Fri, Jul 9, 2010 at 1:32 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote: > > There's a related bug of mine lurking here, only realized in looking > through this, which you might want to fix at the same time: I should > have moved the PageUptodate check from after the pte_same check to > before the ksm_might_need_to_copy, shouldn't I? As it stands, we > might copy junk from an invalid !Uptodate page into a clean new page. Actually, not so, forget it: though it does look worrying, if the swap page read had failed, leaving the page !Uptodate, then it would not have been inserted into any address space in the first place, page->mapping would remain unset, and ksm_might_need_to_copy() would have no reason to copy it. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href