On Thu, Jul 01, 2010 at 09:07:02AM +0900, KOSAKI Motohiro wrote: > > On Wed, Jun 30, 2010 at 06:27:52PM +0900, KOSAKI Motohiro wrote: > > > Now, select_bad_process() have PF_KTHREAD check, but oom_kill_process > > > doesn't. It mean oom_kill_process() may choose wrong task, especially, > > > when the child are using use_mm(). > > > > Is it possible child is kthread even though parent isn't kthread? > > Usually unhappen. but crappy driver can do any strange thing freely. > As I said, oom code should have conservative assumption as far as possible. Okay. You change the check with oom_unkillable_task at last. The oom_unkillable_task is generic function so that the kthread check in oom_kill_process is tivial, I think. Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>