Re: [S+Q 10/16] slub: Remove static kmem_cache_cpu array for boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 26 Jun 2010, David Rientjes wrote:

> > @@ -2105,7 +2096,7 @@ static void early_kmem_cache_node_alloc(
> >
> >  	BUG_ON(kmalloc_caches->size < sizeof(struct kmem_cache_node));
> >
> > -	page = new_slab(kmalloc_caches, GFP_KERNEL, node);
> > +	page = new_slab(kmalloc_caches, GFP_KERNEL & gfp_allowed_mask, node);
> >
> >  	BUG_ON(!page);
> >  	if (page_to_nid(page) != node) {
>
> This needs to be merged into the preceding patch since it had broken new
> slab allocations during early boot while irqs are still disabled; it also
> seems deserving of a big fat comment about why it's required in this
> situation.

AFAICT The earlier patch did not break anything but leave existing
behavior the way it was. Breakage would occur in this patch because it
results in allocations occurring earlier during boot.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]