On Fri 18-06-10 12:21:35, Peter Zijlstra wrote: > On Thu, 2010-06-17 at 20:04 +0200, Jan Kara wrote: > > + /* > > + * Now we can wakeup the writer which frees wc entry > > + * The barrier is here so that woken task sees the > > + * modification of wc. > > + */ > > + smp_wmb(); > > + __wake_up_locked(&bdi->wb_written_wait, TASK_NORMAL); > > wakeups imply a wmb. Thanks. Removed smp_wmb and updated comment. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>