Re: [PATCH 1/2] percpu: make @dyn_size always mean min dyn_size in first chunk init functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Jun 2010, Tejun Heo wrote:

> It would be a good idea to add BUILD_BUG_ON() in slab to verify
> allocation limits against PERCPU_DYNAMIC_EARLY_SIZE/SLOTS.  Please
> note that two alloc slots might be necessary for each allocation and
> there can be gaps in allocation due to alignment, so giving it some
> headroom would be better.
>
> Please let me know if it's okay for slab.  I'll push it through
> percpu#for-next then.

We need SLUB_PAGE_SHIFT * sizeof(kmem_cache_cpu). So it would be

BUILD_BUG_ON(PERCPU_DYNAMIC_EARLY_SIZE < SLUB_PAGE_SHIFT * sizeof(struct
kmem_cache_cpu))?

What is the role of SLOTS?

Each kmem_cache_cpu structure is a separate percpu allocation.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]