On Thu 17-06-10 08:15:41, Dave Chinner wrote: > On Wed, Jun 16, 2010 at 06:33:49PM +0200, Jan Kara wrote: > > Hello, > > > > here is the fourth version of the writeback livelock avoidance patches > > for data integrity writes. To quickly summarize the idea: we tag dirty > > pages at the beginning of write_cache_pages with a new TOWRITE tag and > > then write only tagged pages to avoid parallel writers to livelock us. > > See changelogs of the patches for more details. > > I have tested the patches with fsx and a test program I wrote which > > checks that if we crash after fsync, the data is indeed on disk. > > If there are no more concerns, can these patches get merged? > > Has it been run through xfstests? I'd suggest doing that at least > with XFS as there are several significant sync sanity tests for XFS > in the suite... I've run it through XFSQA with ext3 & ext4 before submitting. I'm running a test with xfs now. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>