On Tue, 8 Jun 2010, Andrew Morton wrote: > > > + if (!totalpages) > > > + totalpages = 1; > > > > > > /* > > > - * Superuser processes are usually more important, so we make it > > > - * less likely that we kill those. > > > + * The baseline for the badness score is the proportion of RAM that each > > > + * task's rss and swap space use. > > > */ > > > - if (has_capability_noaudit(p, CAP_SYS_ADMIN) || > > > - has_capability_noaudit(p, CAP_SYS_RESOURCE)) > > > - points /= 4; > > > + points = (get_mm_rss(p->mm) + get_mm_counter(p->mm, MM_SWAPENTS)) * 1000 / > > > + totalpages; > > > + task_unlock(p); > > > > > > /* > > > - * We don't want to kill a process with direct hardware access. > > > - * Not only could that mess up the hardware, but usually users > > > - * tend to only have this flag set on applications they think > > > - * of as important. > > > + * Root processes get 3% bonus, just like the __vm_enough_memory() > > > + * implementation used by LSMs. > > > */ > > > - if (has_capability_noaudit(p, CAP_SYS_RAWIO)) > > > - points /= 4; > > > + if (has_capability_noaudit(p, CAP_SYS_ADMIN)) > > > + points -= 30; > > > > > > CAP_SYS_ADMIN seems no good idea. CAP_SYS_ADMIN imply admin's interactive > > process. but killing interactive process only cause force logout. but > > killing system daemon can makes more catastrophic disaster. > > > > > > Last of all, I'll pulled this one. but only do cherry-pick. > > > > This change was unchangelogged, I don't know what it's for and I don't > understand your comment about it. > It was in the changelog (recall that the badness() function represents a proportion of available memory used by a task, so subtracting 30 is the equivalent of 3% of available memory): Root tasks are given 3% extra memory just like __vm_enough_memory() provides in LSMs. In the event of two tasks consuming similar amounts of memory, it is generally better to save root's task. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>