> The three oom killer sysctl variables (sysctl_oom_dump_tasks, > sysctl_oom_kill_allocating_task, and sysctl_panic_on_oom) are better > declared in include/linux/oom.h rather than kernel/sysctl.c. > > Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> > --- > include/linux/oom.h | 5 +++++ > kernel/sysctl.c | 4 +--- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/linux/oom.h b/include/linux/oom.h > --- a/include/linux/oom.h > +++ b/include/linux/oom.h > @@ -44,5 +44,10 @@ static inline void oom_killer_enable(void) > { > oom_killer_disabled = false; > } > + > +/* sysctls */ > +extern int sysctl_oom_dump_tasks; > +extern int sysctl_oom_kill_allocating_task; > +extern int sysctl_panic_on_oom; > #endif /* __KERNEL__*/ > #endif /* _INCLUDE_LINUX_OOM_H */ > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -55,6 +55,7 @@ > #include <linux/perf_event.h> > #include <linux/kprobes.h> > #include <linux/pipe_fs_i.h> > +#include <linux/oom.h> > > #include <asm/uaccess.h> > #include <asm/processor.h> > @@ -87,9 +88,6 @@ > /* External variables not in a header file. */ > extern int sysctl_overcommit_memory; > extern int sysctl_overcommit_ratio; > -extern int sysctl_panic_on_oom; > -extern int sysctl_oom_kill_allocating_task; > -extern int sysctl_oom_dump_tasks; > extern int max_threads; > extern int core_uses_pid; > extern int suid_dumpable; pulled. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>