One more comment. > + ret = res_counter_charge(&mem->res, csize, &fail_res); > + > + if (likely(!ret)) { > + if (!do_swap_account) > + return CHARGE_OK; > + ret = res_counter_charge(&mem->memsw, csize, &fail_res); > + if (likely(!ret)) > + return CHARGE_OK; > + > + mem_over_limit = mem_cgroup_from_res_counter(fail_res, res); This must be mem_cgroup_from_res_counter(fail_res, memsw). We will access to an invalid pointer, otherwise. > + flags |= MEM_CGROUP_RECLAIM_NOSWAP; > + } else > + mem_over_limit = mem_cgroup_from_res_counter(fail_res, res); > + Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>