> > Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> > > Cc: David Rientjes <rientjes@xxxxxxxxxx> > > Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > > Could you see my previous comment? > http://lkml.org/lkml/2010/6/2/325 > Anyway, I added my review sign > > Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> Sorry, I had lost your comment ;) But personally I don't like find_alive_subthread() because such function actually does, 1) iterate threads in the same thread group 2) find alive (a.k.a have ->mm) thread 3) lock the task and, I think (3) is most important role of this function. So, I prefer to contain "lock" word. Otherwise, people easily forget to cann task_unlock(). But I'm ok to rename any give me better name. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>