Mel, other than this nit are you happy with these changes now? > > It adds another header dependency which is bad but moving hugetlb stuff > > into mm.h seems bad too. > > I have another choice to move the definition of is_vm_hugetlb_page() into > mm/hugetlb.c and introduce declaration of this function to pagemap.h, > but this needed a bit ugly #ifdefs and I didn't like it. > If putting hugetlb code in mm.h is worse, I'll take the second choice > in the next post. You could always create a new include file hugetlb-inlines.h -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>