On Fri, May 21, 2010 at 03:03:40PM +0530, Ankita Garg wrote: > > I tried the patchset on a non-NUMA machine. So, inorder to create fake > NUMA nodes and be able to emulate the hotplug behavior, I used the > following commandline: > > "numa=fake=4 numa=hide=2*2048" > > on a machine with 8G memory. I expected to see 4 nodes, out of which 2 > would be hidden. However, the system comes up the 4 online nodes and 2 > offline nodes (thus a total of 6 nodes). While we could decide this to > be the semantics, however, I feel that numa=fake should define the total > number of nodes. So in the above case, the system should have come up > with 2 online nodes and 2 offline nodes. Ankita, it is the expected result, NUMA_EMU and NUMA_HOTPLUG_EMU are 2 different features, there is no dependency between the 2 features. Even if you disable NUMA_EMU, the hotplug emualation still working, this implementatin reduces the dependency, it make things simple and easy to understand. You concern makes sense in semantices, but we do not pefer to combine 2 independent modules together. > > Also, "numa=hide=N" could also be supported, with the size > of the hidden nodes being equal to the entire size of the node, with or > without numa=fake parameter. > > On onlining one of the offline nodes, I see another issue that the > memory under it is not automatically brought online. For example: > > #ls /sys/devices/system/node > .... node0 node1 node2.. > > #cat /sys/devices/system/node/probe > 3 > > #echo 3 > /sys/devices/system/node/probe > #ls /sys/devices/system/node > .... node0 node1 node2 node3 > > #cat /sys/devices/system/node/node3/meminfo > Node 3 MemTotal: 0 kB > Node 3 MemFree: 0 kB > Node 3 MemUsed: 0 kB > Node 3 Active: 0 kB > ...... > > i.e, as memory-less nodes. However, these nodes were designated to have > memory. So, on onlining the nodes, maybe we could have all their memory > brought into online state as well ? it is the same result with the real implemetation for memory hotplug in linux kernel, when we hot-add physical memory into machine, the linux kernel create the memory entires and create the related data structure, but the OS will never online the memory, it should finish in user space. the node hotplug emulation and memory hotplug emualtioni feature follows up the same rules with the kernel. As we know, when we allocate memory from a memory-less node, it will cause a OOM issue, Some engineer is already focus on this bug. Because of the OOM issue can be reproduced with the hotplug emulator, it helps the engineer so much. This feature is flexible. As I know, Some OSV already online the hotplug memory automatically, if the mainline kernel decide do the same thing, we will change the related code, too. > > -- > Regards, > Ankita Garg (ankita@xxxxxxxxxx) > Linux Technology Center > IBM India Systems & Technology Labs, > Bangalore, India -- Thanks & Regards, Shaohui -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>