RE: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



sure. glad to a fix on this! 
 

-----Original Message-----
From: Pekka Enberg [mailto:penberg@xxxxxxxxxxxxxx] 
Sent: 2010年5月22日 16:36
To: Duyck, Alexander H
Cc: cl@xxxxxxxxx; linux-mm@xxxxxxxxx; Shi, Alex; yanmin_zhang@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; rjw@xxxxxxx
Subject: Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the 
> local kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
> 
> On my system with 2 nodes I saw around a 5% performance increase w/ 
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average.  
> I suspect the performance gain would increase as the number of nodes 
> increases, but I do not have the data to currently back that up.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>

Thanks for the fix, Alexander!

Yanmin and Alex, can I have your Tested-by or Acked-by please so we can close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e" 
after this patch is merged?

			Pekka
?韬{.n???檩jg???a?旃???)钋???骅w+h?璀?y/i?⒏??⒎???Щ??m???)钋???痂?^??觥??ザ?v???O璁?f??i?⒏?

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]