On Fri, 21 May 2010, Duyck, Alexander H wrote: > Christoph Lameter wrote: > > struct kmem_cache is allocated without any alignment so the alignment > > spec does not work. > > > > If you want this then you also need to align struct kmem_cache. > > internode aligned would require the kmem_cache to be page aligned. So > > lets drop the hunk from this patch for now. A separate patch may > > convince us to merge aligning kmem_cache_node within kmem_cache. > > I will pull that hunk out, test it, and resubmit within the next hour or so if everything looks good. Again internode aligned may need page alignment. You may be getting into messy issues. The architectures requiring internode alignment are NUMA anyways so it may not matter because you only have local_node for the SMP case. Cacheline alignment therefore may be sufficient. But the variables at the tail of the kmem_cache structure are mostly read only. Therefore may be just forget about the alignment. It likely makes no difference. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>