Re: [patch 5/5] vmscan: remove may_swap scan control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, May 13, 2010 at 12:36:12PM +0900, KOSAKI Motohiro wrote:
> > > The may_swap scan control flag can be naturally merged into the
> > > swappiness parameter: swap only if swappiness is non-zero.
> > 
> > Sorry, NAK.
> > 
> > AFAIK, swappiness==0 is very widely used in MySQL users community.
> > They expect this parameter mean "very prefer to discard file cache 
> > rather than swap, but not completely disable swap".
> > 
> > We shouldn't ignore the real world use case. even if it is a bit strange.
> 
> Bummer.  It's really ugly to have 'zero' mean 'almost nothing'.
> 
> But since swappiness is passed around as an int, I think we can
> instead use -1 for 'no swap'.  Let me look into it and send a
> follow-up patch for this as well.
> 
> Thanks!

Yup, -1 is perfectly acceptable.

Moreover, I hope such strange habbit will disappear int the future.
I think our recent activity help to change their mind.
At that time, we can change the code more radically.


Thanks.




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]