On Mon, 2010-05-10 at 17:39 +0200, Thomas Gleixner wrote: > > +#define for_each_lmb(lmb_type, region) \ > > + for (reg = lmb.lmb_type.regions; \ > > + region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \ > > + region++) > > + > > Can you please make this: > > #define for_each_lmb(lmb_type, region, __iter) \ > for (__iter = lmb.lmb_type.regions; \ > region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \ > region++) > > so we do not have the iterator name hardcoded inside the macro body. As a matter of fact, we didn't, but I made a typo on the first one: - for (reg = lmb.lmb_type.regions; \ + for (region = lmb.lmb_type.regions; \ region < (lmb.lmb_type.regions + lmb.lmb_type.cnt); \ region++) I'll fix that in my series. Cheers, Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>